Etablert tilsyn forbedringer #7140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prøver å forbedre lesbarheten
There was a problem hiding this comment.
PR Overview
This PR introduces improvements and refactoring for the established oversight (etablert tilsyn) feature. Key changes include:
- Updating Storybook stories to use function mocks (fn) and enhanced play function steps.
- Refactoring data fetching in EtablertTilsynContainer to use react-query along with transformation functions and removing the old reducer approach.
- Adjustments in UI components for better type safety and optional chaining, as well as improvements to component prop definitions and return types.
Reviewed Changes
| File | Description |
|---|---|
| packages/fakta-etablert-tilsyn/src/ui/EtablertTilsyn.stories.tsx | Updated import and story configuration with function mocks. |
| packages/fakta-etablert-tilsyn/src/ui/components/etablertTilsyn/EtablertTilsynMedSmoring.tsx | Improved type declarations and simplified unique array extraction. |
| packages/fakta-etablert-tilsyn/src/ui/EtablertTilsynContainer.tsx | Migrated from reducer-based state management to react-query for data fetching. |
| packages/fakta-etablert-tilsyn/src/ui/components/etablertTilsyn/EtablertTilsynDag.tsx | Made timer and kilde optional and updated rendering of icons accordingly. |
| packages/fakta-etablert-tilsyn/src/util/dateUtils.ts | Adjusted plugin import order and added explicit type annotations. |
| Other files | Various adjustments for type-safety, conditional rendering, and removal of deprecated files (mainReducer and mainActionTypes). |
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
packages/fakta-etablert-tilsyn/src/ui/components/vurderingsperiode/VurderingsperiodeElement.tsx:16
- The renderStatusIcon function does not handle a null 'resultat' value. Consider adding a null check or a default icon to prevent unintended behavior when 'resultat' is null.
resultat: Vurderingsresultat | null;
packages/fakta-etablert-tilsyn/src/ui/mainReducer.ts:1
- The mainReducer file is completely removed. Ensure that no residual references in the codebase remain that depend on this reducer and that all components have been updated to use the new react-query based data fetching.
import { Period } from '@fpsak-frontend/utils';
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.